Oved Ourfali has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28160/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 60: callBack.onSucceeded(cmdId); Line 61: callBack.notifyCompletion(); Line 62: break; Line 63: case ACTIVE: Line 64: callBack.doPolling(cmdId); so callBack.doPolling can move the command status to SUCCEEDED / ACTIVE? also, we need to set a guideline that the doPolling should only do fast operations like accessing the DB to find out the status, and not go to an external component to do that (like VDSM / other external component). Line 65: break; Line 66: } Line 67: } Line 68: clearCompletedCommands(); -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
