Mike Kolesnik has uploaded a new change for review. Change subject: engine: Change SetupNetworks diff recognition ......................................................................
engine: Change SetupNetworks diff recognition SetupNetworks would recognize that NIC definitions changed by comparing the new NIC from parameters, to the old NIC from the DB. If the NIC is different then the network/bond is a candidate to be sent to the Host as changed. This approach is problematic if a parameter that is not being sent to the Host is changed, and in turn causes a "false positive" recognition. Changed the difference recognition to take into account only parameters that are later on passed to the host: Network name, Bonding options (would matter for bond), Boot protocol, Specific parameters for Static: IP, Gateway, Netmask. Change-Id: I1908508aee8b1e1dac8e69b86f6cee5380664be6 Signed-off-by: Mike Kolesnik <mkole...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 118 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/5390/1 -- To view, visit http://gerrit.ovirt.org/5390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1908508aee8b1e1dac8e69b86f6cee5380664be6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
