Yair Zaslavsky has posted comments on this change. Change subject: engine : Support logging of commands parameters ......................................................................
Patch Set 7: Code-Review+1 (1 comment) minor comment. http://gerrit.ovirt.org/#/c/27780/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeUserPasswordParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeUserPasswordParameters.java: Line 12: private String _newPassword; Line 13: Line 14: private String _domain; Line 15: Line 16: public ChangeUserPasswordParameters(String userName, String userPassword, String newPassword, String domain) { IMHO this class should be removed, I think the mathing command does not exist anymore. Line 17: _userName = userName; Line 18: _userPassword = userPassword; Line 19: _newPassword = newPassword; Line 20: _domain = domain; -- To view, visit http://gerrit.ovirt.org/27780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd9423e92f9f9c9a51eca24b20157cc32681018 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
