Lior Vernia has posted comments on this change. Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 3 ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/28015/2/packaging/branding/ovirt.brand/patternfly-custom-hacks.css File packaging/branding/ovirt.brand/patternfly-custom-hacks.css: Line 465: } Line 466: .nicp_actionButton_pfly_fix img, .np_actionButton_pfly_fix img, .bp_actionButton_pfly_fix img { Line 467: position: relative; Line 468: left: 3px !important; Line 469: top: -3px !important; NicPanel and NetworkPanel are similar, so if it looks good for one it probably looks good for the other. How about BondPanel though? Does it work there too? Line 470: } Line 471: .np_actionButton_pfly_fix, .np_actionButton_pfly_fix img { Line 472: cursor: pointer; Line 473: } Line 468: left: 3px !important; Line 469: top: -3px !important; Line 470: } Line 471: .np_actionButton_pfly_fix, .np_actionButton_pfly_fix img { Line 472: cursor: pointer; This is probably relevant to all of them. It might even be worth it to remove the style ".actionButtonNetwork" from HostSetupNetworksPopupView.ui.xml, to have it all in one place. Line 473: } Line 474: @media screen and (-webkit-min-device-pixel-ratio:0) { Line 475: .cppv_editors_pfly_fix input { Line 476: position: relative; -- To view, visit http://gerrit.ovirt.org/28015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
