Lior Vernia has posted comments on this change. Change subject: webadmin: KeyValueModel to reuse CustomPropertiesUtils code ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/27387/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java: Line 209 Line 210 Line 211 Line 212 Line 213 > I'd be really glad that you'd add tests to the code, and see that these tes What exactly would you like me to test that isn't already tested? The conversion between Map and String is already tested in the Common utilities, that's part of the advantage of reusing it. I don't understand how "duplicate tests" is something that's desirable and how that would be beneficial. -- To view, visit http://gerrit.ovirt.org/27387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5294f8d14149bff14f26a68d13b522a4cc4e97f2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
