Maor Lipchuk has posted comments on this change. Change subject: core: support for querying connections of domains in given statuses ......................................................................
Patch Set 4: Code-Review+2 (4 comments) http://gerrit.ovirt.org/#/c/27521/4/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java: Line 177: StorageType.NFS, Line 178: statuses); Line 179: Line 180: assertNotNull(result); Line 181: assertFalse(result.isEmpty()); please add a message Line 182: Line 183: for (StorageServerConnections storageServerConnection : result) { Line 184: assertEquals(StorageType.NFS, storageServerConnection.getstorage_type()); Line 185: } Line 180: assertNotNull(result); Line 181: assertFalse(result.isEmpty()); Line 182: Line 183: for (StorageServerConnections storageServerConnection : result) { Line 184: assertEquals(StorageType.NFS, storageServerConnection.getstorage_type()); please add a message Line 185: } Line 186: Line 187: List<StoragePoolIsoMap> poolIsoMap = dbFacade.getStoragePoolIsoMapDao().getAllForStoragePool(FixturesTool.STORAGE_POOL_MIXED_TYPES); Line 188: List<Guid> storageDomainIds = new LinkedList<>(); Line 191: storageDomainIds.add(isoMap.getstorage_id()); Line 192: } Line 193: } Line 194: Line 195: assertTrue(CollectionUtils.isEqualCollection(expectedDomains, storageDomainIds)); please add a message Line 196: Line 197: List<StorageServerConnections> domainConnections = new LinkedList<>(); Line 198: for (Guid domainId : storageDomainIds) { Line 199: domainConnections.addAll(dao.getAllForDomain(domainId)); Line 198: for (Guid domainId : storageDomainIds) { Line 199: domainConnections.addAll(dao.getAllForDomain(domainId)); Line 200: } Line 201: Line 202: assertTrue(CollectionUtils.isEqualCollection(domainConnections, result)); please add a message Line 203: } Line 204: /** Line 205: * Retrieves all connections for the given volume group. Line 206: * -- To view, visit http://gerrit.ovirt.org/27521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie05c371b37fb0cb2c723e6aee3d416abd0d8eb20 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
