Arik Hadas has posted comments on this change. Change subject: core: move the logic in VmPoolHandler to separate command ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28144/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java: Line 44: } Line 45: Line 46: @Override Line 47: protected void executeCommand() { Line 48: Guid vmId = getParameters().getId(); > why not setVmId in ctor, and use getVmId() and getVm() everywhere? good idea, I'll do it in the following patch - this one just moves the code as is, and the next one makes some refactoring Line 49: VmPoolMap map = DbFacade.getInstance().getVmPoolDao().getVmPoolMapByVmGuid(vmId); Line 50: List<DbUser> users = DbFacade.getInstance().getDbUserDao().getAllForVm(vmId); Line 51: // Check if this is a Vm from a Vm pool, and is attached to a user Line 52: if (map != null && users != null && !users.isEmpty()) { -- To view, visit http://gerrit.ovirt.org/28144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8840b8cba0fcec68936f0f24abc9948568cca0d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
