Roy Golan has posted comments on this change. Change subject: core: move VM status handling to VdsManager. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28114/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 21: public class VdsNotRespondingTreatmentCommand<T extends FenceVdsActionParameters> extends RestartVdsCommand<T> { Line 22: /** Line 23: * use this member to determine if fence failed but vms moved to unknown mode (for the audit log type) Line 24: */ Line 25: private boolean _vmsMovedToUnknown; > this needs retro fitting. the audit log depends on it I know the comment wasn't clear... just lookup for usages of this boolean and you'll see its not relevant for this class since its not moving the VMs to down anymore. Line 26: private static final String RESTART = "Restart"; Line 27: Line 28: public VdsNotRespondingTreatmentCommand(T parameters) { Line 29: super(parameters); -- To view, visit http://gerrit.ovirt.org/28114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7304109b49a0fb8441f9fdc9aee6edb0c654ab0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
