Jiří Moskovčák has posted comments on this change. Change subject: WIP: use VDSM for creating volumes ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/28237/4/ovirt_hosted_engine_ha/lib/storage_backends.py File ovirt_hosted_engine_ha/lib/storage_backends.py: Line 178: image_uuid, Line 179: volume_uuid Line 180: ) Line 181: Line 182: logger.debug("getVolumePath: %s", response) please use '%s' instead of plain %s Line 183: if response["status"]["code"] == 0: Line 184: logger.info("Image for %s already exists", service_name) Line 185: path = response['path'] Line 186: return False, path Line 180: ) Line 181: Line 182: logger.debug("getVolumePath: %s", response) Line 183: if response["status"]["code"] == 0: Line 184: logger.info("Image for %s already exists", service_name) same here and in the rest of the log messages... Line 185: path = response['path'] Line 186: return False, path Line 187: Line 188: elif response["status"]["code"] != 100: Line 289: Line 290: def get_device(self, service): Line 291: """ Line 292: This method gives access to the underlying Device objects so it is possible Line 293: to retrieve the volume ang image UUIDs. typo: ang -> and Line 294: """ Line 295: return self._services[service] Line 296: Line 297: def disconnect(self): -- To view, visit http://gerrit.ovirt.org/28237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeae8bfbe931aa47b7afa36207f712f1335c2bd7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
