Sandro Bonazzola has posted comments on this change. Change subject: WIP: use VDSM for creating volumes ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28237/3/ovirt_hosted_engine_ha/lib/storage_backends.py File ovirt_hosted_engine_ha/lib/storage_backends.py: Line 255: isnew, path = self.create_volume(service_name=service, Line 256: image_uuid=new_image_uuid, Line 257: volume_uuid=new_volume_uuid, Line 258: service_size=size) Line 259: don't we need to create symlinks here? Line 260: if isnew: Line 261: new_set.add(service) Line 262: self._services[service] = self.Device(image_uuid=new_image_uuid, Line 263: volume_uuid=new_volume_uuid, Line 261: new_set.add(service) Line 262: self._services[service] = self.Device(image_uuid=new_image_uuid, Line 263: volume_uuid=new_volume_uuid, Line 264: path=path) Line 265: We need a method for accessing self._services from setup in order to get the UUIDs of the devices for storing them in hosted_engine.conf. Otherwise we need to be able to pass UUIDs to the constructor. Line 266: return new_set Line 267: Line 268: def connect(self): Line 269: """Initialize the storage.""" -- To view, visit http://gerrit.ovirt.org/28237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeae8bfbe931aa47b7afa36207f712f1335c2bd7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
