Lukas Bednar has posted comments on this change. Change subject: Implementation of machine dialog parser for python ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28180/3/src/otopi/machine_dialog_parser.py File src/otopi/machine_dialog_parser.py: Line 153: self.output.write(data) Line 154: self.output.write('\n') Line 155: self.output.flush() Line 156: Line 157: def next_line(self): regarding to binary stream, I am not sure whether this is that what you wanted. Line 158: """ Line 159: Returns next line from input Line 160: """ Line 161: line = "" -- To view, visit http://gerrit.ovirt.org/28180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b715a39840e548ef768ac9e77004cc0d98a9c0 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Lukas Bednar <lbed...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Lukas Bednar <lbed...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches