anmolbabu has posted comments on this change. Change subject: webadmin : Disable status button ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28165/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java: Line 85: } else { Line 86: endStepJob(JobExecutionStatus.ABORTED, getStepMessageMap(JobExecutionStatus.ABORTED), false); Line 87: } Line 88: setSucceeded(vdsReturnaValue.getSucceeded()); Line 89: //getReturnValue().setActionReturnValue(rebalanceStatusEntity); > Remove commented code Done Line 90: getReturnValue().setActionReturnValue(updateStatusEntity(rebalanceStatusEntity)); Line 91: Line 92: } Line 93: http://gerrit.ovirt.org/#/c/28165/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java: Line 86: releaseVolumeLock(); Line 87: getReturnValue().setActionReturnValue(updateStatusEntity((GlusterVolumeTaskStatusEntity)returnValue.getReturnValue())); Line 88: } Line 89: Line 90: protected GlusterVolumeTaskStatusEntity updateStatusEntity(GlusterVolumeTaskStatusEntity status) { > Arent we doing similar things in previous source Ok I am putting them into base class GlusterAsyncCommandBase Line 91: // Set the volume remove bricks start time Line 92: setStartAndStopTime(status); Line 93: // update the latest status Line 94: updateLatestStatus(status); -- To view, visit http://gerrit.ovirt.org/28165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic91f437bd40b43f24f19d23a47297ae78dbd9372 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
