Alexander Wels has posted comments on this change.

Change subject: webadmin: sorting DC tabs
......................................................................


Patch Set 1: Verified+1

Verified that sorting works in all subtabs except for Compatibility version 
which I could not find in the entity model.

@Vojtech I made this work without replacing the SortedSet by guaranteeing that 
each comparator falls back to an entity comparator if the specified comparator 
returns 'equals'. One other way would be to override the sortItems in 
SearchableListModel and sort with a list in there. Then anything that is or 
extends the SortedListModel will still use the SortedSet, but anything that 
extends the SearchableListModel will use the list, what do you think?

-- 
To view, visit http://gerrit.ovirt.org/28225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id95272bd4594a66611c11aaa690d44d88b082b49
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to