Allon Mureinik has posted comments on this change. Change subject: core: minor cleanup on RegisterVdsQuery ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java Line 226: && CheckAutoApprovalDefinitions(isPending) calling the booleanValue() is a bit redundant (it will be outboxed anyway), but that's a matter of style. -- To view, visit http://gerrit.ovirt.org/5352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb7242c686a3b7a725944a5929cf475850b6f8c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches