Federico Simoncelli has posted comments on this change.

Change subject: core: expose the V3 domain format in dc 3.1
......................................................................


Patch Set 11: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
Line 652:                 else if 
(dataCenter.getcompatibility_version().compareTo(Version.v3_1) >= 0) 
//$NON-NLS-1$
http://stackoverflow.com/questions/654037/what-does-non-nls-1-mean

I'm not using eclipse so I can't say if it's still needed.

--
To view, visit http://gerrit.ovirt.org/4476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibafcb53007eb6e531f024cd054ff2673a7d431e1
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to