Daniel Erez has posted comments on this change. Change subject: ui: adding discover host integration to AddHost view ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/27623/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 91: public void onSuccess(Object model, Object result) Line 92: { Line 93: ArrayList<VDS> hosts = (ArrayList<VDS>) result; Line 94: ListModel<VDS> hostNameListModel = getExternalHostName(); Line 95: hosts.add(0, null); needed? Line 96: hostNameListModel.setItems(hosts); Line 97: hostNameListModel.setIsChangable(true); Line 98: hostNameListModel.setSelectedItem(hosts.get(0)); Line 99: setEnableSearchHost(true); http://gerrit.ovirt.org/#/c/27623/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java: Line 412: @UiField(provided=true) Line 413: @Ignore Line 414: InfoIcon consoleAddressInfoIcon; Line 415: Line 416: @UiField(provided=true) s/'provided=true'/'provided = true' Line 417: @Ignore Line 418: InfoIcon discoveredHostInfoIcon; Line 419: Line 420: @UiField(provided=true) Line 416: @UiField(provided=true) Line 417: @Ignore Line 418: InfoIcon discoveredHostInfoIcon; Line 419: Line 420: @UiField(provided=true) same Line 421: @Ignore Line 422: InfoIcon provisionedHostInfoIcon; Line 423: Line 424: @UiField -- To view, visit http://gerrit.ovirt.org/27623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0faf667019760326019368f044ee16265d41a620 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
