Lior Vernia has posted comments on this change. Change subject: webadmin: adding label tag to Host->Interface subtab ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27898/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java: Line 51: row.getColumnFormatter().setWidth(0, "30px"); //$NON-NLS-1$ Line 52: row.getColumnFormatter().setWidth(1, "210px"); //$NON-NLS-1$ Line 53: Line 54: // Check box and interface status icon Line 55: row.setWidget(0, 0, new HorizontalPanel() { > With FlowPanel the status image is under the checkbox (which makes sense ca This should be fixable with "flow: left", but I'm not sure it's that important. Line 56: { Line 57: if (isSelectionAvailable) { Line 58: add(getCheckBox()); Line 59: } -- To view, visit http://gerrit.ovirt.org/27898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I997d85d894d79f14402157fcc51a0cdbfe2ff056 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
