Martin Peřina has posted comments on this change. Change subject: core: Rename finishSshSoftFencingExecution to resetStatusToConnecting in VdsManager ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28140/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java: Line 46: VdsValidator validator = new VdsValidator(getVds()); Line 47: if (validator.shouldVdsBeFenced()) { Line 48: boolean result = executeSshSoftFencingCommand(getVds().getVdsGroupCompatibilityVersion().toString()); Line 49: if (result) { Line 50: // SSH Soft Fencing executed without errors, tell VdsManager about it > Should you update the comment as well? Done Line 51: ResourceManager.getInstance().GetVdsManager(getVds().getId()).resetStatusToConnecting( Line 52: getVds(), Line 53: false); Line 54: } -- To view, visit http://gerrit.ovirt.org/28140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If420606341813ada2ab1b4bf9bd49a7116187fe6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
