Oved Ourfali has posted comments on this change. Change subject: core: VdsManger - rename fields to fit convention ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27378/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 389: } Line 390: } Line 391: Line 392: @Override Line 393: public void setStatus(VDSStatus status, VDS vds) { I suggest either to rename the argument, or perhaps the member name, to avoid future confusion. Line 394: synchronized (getLockObj()) { Line 395: if (vds == null) { Line 396: vds = DbFacade.getInstance().getVdsDao().get(getVdsId()); Line 397: } -- To view, visit http://gerrit.ovirt.org/27378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e26c1a2db4d51f5bd13cf39a59593579fa7648 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
