Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix misc null pointer exceptions ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28194/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 347: Line 348: String principal = outputMap.<String> get(Authn.InvokeKeys.PRINCIPAL); Line 349: if (principal != null) { Line 350: SessionDataContainer.getInstance().setPrincipal(principal); Line 351: } I am unsure why we set this in session before we have validation ack Line 352: int authResult = outputMap.<Integer>get(Authn.InvokeKeys.RESULT); Line 353: if (authResult != Authn.AuthResult.SUCCESS) { Line 354: log.infoFormat( Line 355: "Can't login user \"{0}\" with authentication profile \"{1}\" because the authentication failed.", -- To view, visit http://gerrit.ovirt.org/28194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcd2c3c8dcc0989951d6274bb3d75d7f93c8c728 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
