Daniel Erez has posted comments on this change. Change subject: webadmin: When adding a new VM disk, allow activation in certain VM statuses ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/28147/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java: Line 686: getIsPlugged().setEntity(false); Line 687: } Line 688: else { Line 689: if (!canDiskBePlugged(getVm())) { Line 690: getIsPlugged().setEntity(false); just for consistency - reorder statements as the else branch.. Line 691: getIsPlugged().setChangeProhibitionReason(CONSTANTS.cannotPlugDiskIncorrectVmStatus()); Line 692: getIsPlugged().setIsChangable(false); Line 693: } Line 694: else { -- To view, visit http://gerrit.ovirt.org/28147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd625adb50ceaee3754f317d5751b78e29f7ea25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
