Ravi Nori has posted comments on this change. Change subject: engine : Introduction of CallBack interface ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/26333/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java: Line 13: import org.ovirt.engine.core.compat.Guid; Line 14: Line 15: public class TaskManagerUtil { Line 16: Line 17: public static final CommandCoordinatorImpl coco = new CommandCoordinatorImpl(); > I fixed it at a latter patch, but I think this is the right place to fix it I see why I did not change it here, a lot of the methods in CoCo are introduced in later patches as interfaces. But it gets fixed in later patches Line 18: Line 19: public static void startPollingTask(Guid taskID) { Line 20: getAsyncTaskManager().startPollingTask(taskID); Line 21: } -- To view, visit http://gerrit.ovirt.org/26333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c12315c96168fd32dc05ac6de336ccdd63c9fbc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
