Michael Kublin has submitted this change and it was merged. Change subject: core: Cleanup LUN pathes parsing ......................................................................
core: Cleanup LUN pathes parsing This patch unifies the code that parses LUN paths from the two places it was separated in GetDeviceListVDSCommand. A unit test for the path parsing was also added to make sure no functionallity was harmed. In addition, some general cleanups (replacing FQCNs with imports, extracting constants, etc.) was done in that area. Change-Id: Ife28fb2d0326fbaaf4a8562d2d709351c75aee81 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java 2 files changed, 84 insertions(+), 27 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife28fb2d0326fbaaf4a8562d2d709351c75aee81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
