Arik Hadas has posted comments on this change. Change subject: engine : Introduction of TaskHelper interface ......................................................................
Patch Set 8: (3 comments) partial review http://gerrit.ovirt.org/#/c/26334/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java: Line 540: */ Line 541: synchronized private void removeClearedAndOldTasks() { Line 542: Set<Guid> poolsOfActiveTasks = new HashSet<Guid>(); Line 543: Set<Guid> poolsOfClearedAndOldTasks = new HashSet<Guid>(); Line 544: ConcurrentMap<Guid, SPMTask> activeTaskMap = new ConcurrentHashMap<Guid, SPMTask>(); if it is changed, don't you prefer to use diamond operator? Line 545: for (SPMTask task : _tasks.values()) { Line 546: if (!cachingOver(task)) { Line 547: activeTaskMap.put(task.getVdsmTaskId(), task); Line 548: poolsOfActiveTasks.add(task.getStoragePoolID()); http://gerrit.ovirt.org/#/c/26334/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/SPMTask.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/SPMTask.java: Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: import java.util.Map; Line 10: Line 11: public interface SPMTask { why do we need this interface? there will be other kinds of SPM tasks? Line 12: void concreteStartPollingTask(); Line 13: Line 14: void startPollingTask(); Line 15: http://gerrit.ovirt.org/#/c/26334/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/TaskHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/TaskHelper.java: Line 1: /* Line 2: * To change this template, choose Tools | Templates Line 3: * and open the template in the editor. should be removed Line 4: */ Line 5: package org.ovirt.engine.core.bll.tasks.interfaces; Line 6: Line 7: import java.util.ArrayList; -- To view, visit http://gerrit.ovirt.org/26334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c5b3db8d679096aab5d791ba61084d54c26b9de Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
