Arik Hadas has posted comments on this change. Change subject: engine : Introduction of Poller, CommandEntity and interfaces for caching ......................................................................
Patch Set 8: (1 comment) partial review http://gerrit.ovirt.org/#/c/26335/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandEntityUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandEntityUtils.java: Line 18: Line 19: public static VdcActionParametersBase getParameters(CommandEntity commandEntity) { Line 20: return commandEntity.getData() != null ? (VdcActionParametersBase) commandEntity.getData().get(PARAMETERS_KEY) Line 21: : null; Line 22: } how about initialize CommandEntity#data to empty map in CommandEntity instead of all those null checks? -- To view, visit http://gerrit.ovirt.org/26335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2172333255131652bb78623352fb805d16fb4a1b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
