Martin Peřina has posted comments on this change. Change subject: core: Add ExternalVariable entity ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27934/2/packaging/dbscripts/external_variable_sp.sql File packaging/dbscripts/external_variable_sp.sql: Line 2: -- Table external_variable Line 3: -- Line 4: Line 5: -- UpsertExternalVariable is used in fence_kdump listener Line 6: CREATE OR REPLACE FUNCTION UpsertExternalVariable( > Why taking a different approach of all DAOs that implement insert/update se I expect the table is used to share data between engine and external service. So in this usecase it seems to me uncomfortable to test if record exist and do insert or update by result. But if you wish I can add also classic insert and update calls ... Line 7: v_var_name VARCHAR(50), Line 8: v_var_value VARCHAR(255), Line 9: v_updated TIMESTAMP WITH TIME ZONE) Line 10: RETURNS VOID -- To view, visit http://gerrit.ovirt.org/27934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61ffd646c102c01c34478309d072f74a8f7d7edf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
