Martin Peřina has posted comments on this change. Change subject: core: Add VdsKdumpStatus entity ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/27200/12/packaging/dbscripts/upgrade/03_05_0500_add_vds_kdump_status.sql File packaging/dbscripts/upgrade/03_05_0500_add_vds_kdump_status.sql: Line 1: CREATE TABLE vds_kdump_status ( Line 2: vds_id UUID NOT NULL, Line 3: status VARCHAR(20) NOT NULL, Line 4: address VARCHAR(50) NOT NULL, > Can this be a full FQDN and 50 chars may be not enough for that ??? No, it's JSON encoded IP and port, for example ["192.168.1.1", 7410] Alon wanted this to be named address and he didn't want to separate this into 2 fields, which seems logical to me ... Line 5: CONSTRAINT pk_vds_kdump_status PRIMARY KEY(vds_id) Line 6: ) WITH OIDS; Line 7: Line 8: ALTER TABLE ONLY vds_kdump_status http://gerrit.ovirt.org/#/c/27200/12/packaging/dbscripts/vds_kdump_status_sp.sql File packaging/dbscripts/vds_kdump_status_sp.sql: Line 1: ---------------------------------------------------------------- Line 2: -- [vds_kdump_status] Table Line 3: ---------------------------------------------------------------- Line 4: Line 5: -- UpsertKdumpStatus is used in fence_kdump listener > Again , what is the reason to introduce upsterts Here it's easy listener inserts/updates record, engine removes record with status finished. So using upsert move insert/update logic into db and make listener code simpler Line 6: CREATE OR REPLACE FUNCTION UpsertKdumpStatus( Line 7: v_vds_id UUID, Line 8: v_status VARCHAR(20), Line 9: v_address VARCHAR(50)) -- To view, visit http://gerrit.ovirt.org/27200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58696ddefa8602b1daa5f55ab4dc11bdc565e265 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
