Yaniv Bronhaim has posted comments on this change.

Change subject: core: Foreman discovery host integration to ovirt
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/27621/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java:

Line 334:                 } else if (!getParameters().getAddPending()
Line 335:                         && (getParameters().getAuthMethod() == 
AuthenticationMethod.Password)
Line 336:                         && 
StringUtils.isEmpty(getParameters().getPassword())) {
Line 337:                     // We block vds installations if it's not a 
RHEV-H and password is empty
Line 338:                     // Note that this may override local host SSH 
policy. See BZ#688718.
if provision ovirt-node , empty password is valid. the password set in the 
provision template. we still need to define how user will pick the node password
Line 339:                     returnValue = 
failCanDoAction(VdcBllMessages.VDS_CANNOT_INSTALL_EMPTY_PASSWORD);
Line 340:                 } else if (!isPowerManagementLegal()) {
Line 341:                     returnValue = false;
Line 342:                 } else {


-- 
To view, visit http://gerrit.ovirt.org/27621
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c25a544373d8ab4a7123137c8a4697205a8efa8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to