Gilad Chaplik has posted comments on this change. Change subject: engine: fix clutser policy bugs ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28161/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java: Line 118: } Line 119: return true; Line 120: } Line 121: Line 122: private boolean isPolicyUnitExist(Guid policyUnitId, Set<Guid> existingPolicyUnits) { > /s/isPolicyUnitExist/isPolicyUnitExists/ Done Line 123: return !existingPolicyUnits.add(policyUnitId); Line 124: } Line 125: Line 126: protected boolean checkRemoveEditValidations() { http://gerrit.ovirt.org/#/c/28161/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1109: QOS_NAME_TOO_LONG=QoS name length must be under 255 characters. Line 1110: Line 1111: # cluster policy errors Line 1112: ACTION_TYPE_FAILED_CLUSTER_POLICY_PARAMETERS_INVALID=Cannot ${action} ${type}. Parameters are invalid. Line 1113: ACTION_TYPE_FAILED_CLUSTER_POLICY_DUPLICATE_POLICY_UNIT=Cannot ${action} ${type}. policy unit already exists in cluster policy. > s/. policy/. Policy/ Changed to 'Cluster Policy' (in other places as well). Done. Line 1114: ACTION_TYPE_FAILED_CLUSTER_POLICY_NAME_INUSE=Cannot ${action} ${type}. Name is in use. Line 1115: ACTION_TYPE_FAILED_CLUSTER_POLICY_LOCKED=Cannot ${action} ${type}. Cluster Policy is locked, and cannot be editable. Line 1116: ACTION_TYPE_FAILED_CLUSTER_POLICY_INUSE=Cannot ${action} ${type}. Cluster Policy is attached to cluster(s), please assign these cluster(s) to other policy. Line 1117: ACTION_TYPE_FAILED_CLUSTER_POLICY_UNKNOWN_POLICY_UNIT=Cannot ${action} ${type}. Policy unit is unknown. -- To view, visit http://gerrit.ovirt.org/28161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I136e42882c1642380eb641689fc39f3a72d1f789 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
