Simone Tiraboschi has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26878/4/src/ovirt_hosted_engine_setup/check_liveliness.py File src/ovirt_hosted_engine_setup/check_liveliness.py: Line 103: ), Line 104: username='admin@internal', Line 105: password=self.environment[ Line 106: ohostedcons.EngineEnv.ADMIN_PASSWORD, Line 107: ], I've to check if I'm able to discriminate a wrong password response from any other error; replying with a wrong password indication it's by itself an indication that the engine is alive and I think we don't need more than that. In that can we can avoid to store or ask the engine password for interactive and HA demon execution of this check. Line 108: # it's simply a ping, we are basically Line 109: # trusting any certs Line 110: ca_file=self._cacert, Line 111: ) -- To view, visit http://gerrit.ovirt.org/26878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3522ccb82eee4bf7f04ded012d9badc97c55b5a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
