Simone Tiraboschi has posted comments on this change. Change subject: ovirt-iso-uploader: using API SDK insecure parameter ......................................................................
Patch Set 1: I'm not sure about it cause it's not a new parameter on SDK side, it was called insecure also in the past. Due to a bug ovirt-iso-uploader wasn't using it but fortunately or unfortunately the SDK wasn't checking the hostname versus what stated in the SSL cert and so it was basically always in the insecure mode. When Juan fixed that secure mode started working and it shows up that we were not using the insecure option in the correct way. So, the secure way was bugged but the insecure option was already working and so on my opinion we don't need to require a dependency from the newer fixed SDK just for this. -- To view, visit http://gerrit.ovirt.org/28153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c76ee34b51bfe111ff319f4e75b7ddb09f03bcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
