Oved Ourfali has submitted this change and it was merged. Change subject: engine: UserRole permission on System/DC/Cluster doesn't work as expected ......................................................................
engine: UserRole permission on System/DC/Cluster doesn't work as expected When granting UserRole permission on System/DC/Cluster, it allows the user to see all the VMs under that entity (System/DC/Cluster), including Pooled VMs. The result is that he will see all the VMs (including the Pooled VM) in the User Portal, but he won't see the VM Pools (as the logic is to show only pools that the user has no UserRole on at least one VM from this pool). Change-Id: If106d64939b80de65fb7052e97f69a6d5de0b010 Bug-Url: https://bugzilla.redhat.com/863074 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsAndVmPoolsQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForUserQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 47 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If106d64939b80de65fb7052e97f69a6d5de0b010 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches