Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: Tooltip infrastructure ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/27325/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/TooltipPanel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/TooltipPanel.java: Line 167: if (BrowserEvents.MOUSEOUT.equals(event.getType())) { Line 168: onTooltipSourceMouseOut(); Line 169: TooltipPanel.this.hide(true); Line 170: } else if (BrowserEvents.MOUSEOVER.equals(event.getType())) { Line 171: displayTooltipPanel(tooltipSource); > If you notice that it calls displayTooltipPanel, that method calls onToolti I see, I was just wondering that these onXxx callbacks were not called on same "call stack" level, but it's not a big deal. Line 172: } Line 173: } Line 174: Line 175: /** http://gerrit.ovirt.org/#/c/27325/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextBox.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextBox.java: Line 12: public class EntityModelTextBox<T> extends ValueBox<T> implements EditorWidget<T, ValueBoxEditor<T>> { Line 13: Line 14: private ObservableValueBoxEditor<T> editor; Line 15: Line 16: private final TooltipPanel tooltipPanel = new TooltipPanel(true, this); > The constructor where you pass 'this' is a convenience constructor that aut Thanks for clarification, I agree. Line 17: Line 18: public EntityModelTextBox(Renderer<T> renderer, Parser<T> parser) { Line 19: super(Document.get().createTextInputElement(), renderer, parser); Line 20: } -- To view, visit http://gerrit.ovirt.org/27325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc79a6aa132c65d3050499e5f00facbb5c358d3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
