Vojtech Szocs has posted comments on this change.

Change subject: userportal,webadmin: additional protection for GWT RPC
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/27024/3/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java:

Line 92:     private String getXsrfServiceEndPoint() {
Line 93:         if (baseUrl == null) {
Line 94:             baseUrl = GWT.getModuleBaseURL();
Line 95:         }
Line 96:         return baseUrl + "xsrf"; //$NON-NLS-1$
> We could if it wasn't a GWT provided interface. But it is so we can't. But 
OK, thanks.
Line 97:     }
Line 98: 
Line 99:     /**
Line 100:      * Constructor.


-- 
To view, visit http://gerrit.ovirt.org/27024
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a5ad1f33eb985aa79e1376aecb48ae365d334d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to