Ravi Nori has posted comments on this change. Change subject: engine : Support logging of commands parameters ......................................................................
Patch Set 2: @Omer Hi Omer Yes I did see how VdsBroker commands print out the parameters by overriding the toString method. But in the case of VdcActionParameters, there are over 200+ classes that need to be modified to support custom printing of parameters if we want to override to string in each of them. My implementation does not pretty print array lists or hash maps but it handles all classes in a single patch. If you still prefer to have toString method overridden in all subclasses of VdcActionParametersBase please let me know. I will change the code to use the framework, but changing 200+ subclasses should be done progressively and I think it is outside the scope of this BZ. -- To view, visit http://gerrit.ovirt.org/27780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd9423e92f9f9c9a51eca24b20157cc32681018 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
