Daniel Erez has posted comments on this change. Change subject: core: Adding import of unregistered VM template ......................................................................
Patch Set 19: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27581/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 62: VmTemplate vmFromConfiguration; Line 63: ovfEntityData = Line 64: getUnregisteredOVFDataDao().getByEntityIdAndStorageDomain(getParameters().getContainerId(), Line 65: getParameters().getStorageDomainId()); Line 66: OvfHelper ovfHelper = new OvfHelper(); nit - move the deceleration one line up.. Line 67: if (ovfEntityData != null) { Line 68: try { Line 69: vmFromConfiguration = ovfHelper.readVmTemplateFromOvf(ovfEntityData.getOvfData()); Line 70: vmFromConfiguration.setVdsGroupId(getParameters().getVdsGroupId()); -- To view, visit http://gerrit.ovirt.org/27581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc184e687cbeebf4aa732c901f98222d5b11097 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
