Pablo Iranzo Gómez has posted comments on this change. Change subject: Avoid hitting performance issues with api listing ......................................................................
Patch Set 2: Code-Review+1 Hi, I've tested against RHEV 3.4 beta2 ############################# [root@rhevm helper]# diff hypervisors.py /root/helper/hypervisors.py 156,157c156 < page_size = 100 < length = page_size --- > length = 100 161,163c160 < # after BZ1025320 default is provide all results < # this limits results on each iteration to page_size < tanda = entity.list(query=query, max=page_size) --- > tanda = entity.list(query=query) [root@rhevm helper]# ls hypervisors.py __init__.py patch.diff [root@rhevm helper]# ovirt- ovirt-host-deploy ovirt-iso-uploader ovirt-sosreport ovirt-sosreport-wrapper [root@rhevm helper]# ovirt- ovirt-host-deploy ovirt-iso-uploader ovirt-sosreport ovirt-sosreport-wrapper [root@rhevm helper]# ovirt-^C [root@rhevm helper]# rhevm-log-collector INFO: Gathering oVirt Engine information... INFO: Gathering PostgreSQL the oVirt Engine database and log files from localhost... Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to skip): About to collect information from 6 hypervisors. Continue? (Y/n): n INFO: Aborting hypervisor collection... Creating compressed archive... INFO: Log files have been collected and placed in /tmp/sosreport-LogCollector-20140526182302.tar.xz. The MD5 for this file is 9e44e2e6bf7265d68d179c50856eebf2 and its size is 8.8M ############################# This will probably need test in an environment with more than 100 hosts, but so far, it doesn't break on mine... -- To view, visit http://gerrit.ovirt.org/28053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c3cf488df334b5dcf43904a4c67f9abcbe38f87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Pablo Iranzo Gómez <pablo.ira...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Pablo Iranzo Gómez <pablo.ira...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
