Eli Mesika has posted comments on this change.

Change subject: core: move VM status handling to VdsManager.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28114/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java:

Line 805:     public boolean isTimeToRetryMaintenance() {
Line 806:         return System.currentTimeMillis() > 
nextMaintenanceAttemptTime;
Line 807:     }
Line 808: 
Line 809:     private void MoveVMsToUnknown() {
> please rename to moveVmsToUknown()
Done
Line 810:         addMigratedVmsNotUpYet();
Line 811:         List<VM> vmList = 
DbFacade.getInstance().getVmDao().getAllRunningForVds(getVdsId());
Line 812:         for (VM vm : vmList) {
Line 813:             destroyVmOnDestination(vm);


-- 
To view, visit http://gerrit.ovirt.org/28114
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7304109b49a0fb8441f9fdc9aee6edb0c654ab0e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to