Darshan N has posted comments on this change. Change subject: ovirt-log-collector:Fix: Ask password before engine log collection. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28065/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-05-23 17:53:50 +0530 Line 4: Commit: ndarshan <dnara...@redhat.com> Line 5: CommitDate: 2014-05-23 18:23:57 +0530 Line 6: Line 7: ovirt-host-deploy:Fix: Password to be asked before engine log collection. > this is not ovirt-host-deploy Done Line 8: Line 9: The Rest-Api password to be asked before collecting the engine log Line 10: whenever needed. Currently the password is asked after collecting Line 11: engine and postgres data. http://gerrit.ovirt.org/#/c/28065/1/src/__main__.py File src/__main__.py: Line 1674: hypervisor data will be collected.") Line 1675: else: Line 1676: collector.get_engine_data() Line 1677: collector.get_postgres_data() Line 1678: logging.info("Skipping hypervisor collection...") > Maybe better something like: Done Line 1679: stdout = collector.archive() Line 1680: logging.info(stdout) Line 1681: elif conf.command == "list": Line 1682: if collector.set_hosts(): -- To view, visit http://gerrit.ovirt.org/28065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e49f3196f5dc5076fe784d7819160dba24e0184 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
