Lior Vernia has posted comments on this change. Change subject: webadmin: Add warning to Setup networks dialog ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27463/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java: Line 193: Line 194: if (!evtArgs.isDrop()) { Line 195: statusLine.setStatusText(message); Line 196: } Line 197: statusLine.setStatusStyle(); P.S. please note that status.setFadeText() has some delay and animation associated with it, but the style updates of status and statusPanel are probably instantaneous (you may verify). However, we would probably want the coloring to take place together with the appearance of the text. So maybe the style changes should happen in StatusLabel or in a listener to an event of StatusLabel (telling that the animation has finished). Line 198: lastStatusLine = statusLine; Line 199: } Line 200: }); Line 201: -- To view, visit http://gerrit.ovirt.org/27463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35f0e019b6f77ab90fec89f614b49db589602353 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
