Allon Mureinik has posted comments on this change. Change subject: core: Showing correct status on attempting to destroy active SD (#819279) ......................................................................
Patch Set 2: (2 inline comments) see inline .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommandTest.java Line 31: why not just inline this? Line 33: ReconstructMasterParameters parameters = new ReconstructMasterParameters(); why do you need the spying? you aren't mocking any behavior here. -- To view, visit http://gerrit.ovirt.org/5260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4042bb35c6a3b47445ef8765af3e5cd082ff3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
