Daniel Erez has uploaded a new change for review. Change subject: webadmin: disable format selection on thin provisioning ......................................................................
webadmin: disable format selection on thin provisioning VM dialog -> resource allocation: disk format should be unchangeable when storage thin provisioning is selected (changing format is applicable only on clone template provisioning). Change-Id: I6b270bb753bcceb4c085db79e413cf9ed3bc04e3 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/28079/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java index 798af1a..3e5054e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java @@ -184,7 +184,7 @@ protected void onPropertyChanged(PropertyChangedEventArgs e) { super.onPropertyChanged(e); - if (e.propertyName.equals("Disks")) //$NON-NLS-1$ + if (e.propertyName.equals("Disks") || e.propertyName.equals("VolumeFormat")) //$NON-NLS-1$ //$NON-NLS-2$ { updateStorageDomainsAvailability(); updateQuotaAvailability(); @@ -290,7 +290,10 @@ } public void setIsVolumeFormatChangable(boolean isVolumeFormatChangable) { - this.isVolumeFormatChangable = isVolumeFormatChangable; + if (this.isVolumeFormatChangable != isVolumeFormatChangable) { + this.isVolumeFormatChangable = isVolumeFormatChangable; + onPropertyChanged(new PropertyChangedEventArgs("VolumeFormat")); //$NON-NLS-1$ + } } public void setIsSourceStorageDomainAvailable(boolean isSourceStorageDomainAvailable) { -- To view, visit http://gerrit.ovirt.org/28079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b270bb753bcceb4c085db79e413cf9ed3bc04e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches