Liron Ar has posted comments on this change. Change subject: core: Add log instead of comment in OvfDataUpdater. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28014/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java: Line 385: Line 386: loadVmData(vm); Line 387: Long currentDbGeneration = getVmStaticDao().getDbGeneration(vm.getId()); Line 388: if (currentDbGeneration == null) { Line 389: log.warnFormat("currentDbGeneration of VM (name: {0}, id: {1}) is null, probably because the VM was deleted during the run of OvfDataUpdater.", it should be debugFormat as there's nothing wrong about that we can use it for debuging if we'll ever need it. Line 390: vm.getName(), Line 391: vm.getId()); Line 392: } else if (vm.getStaticData().getDbGeneration() == currentDbGeneration) { Line 393: proccessedOvfConfigurationsInfo.add(buildMetadataDictionaryForVm(vm, vmsAndTemplateMetadata, vmImages)); -- To view, visit http://gerrit.ovirt.org/28014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94dd7e1f597771054ab2344179acf7cef6ab05d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
