Liron Ar has posted comments on this change. Change subject: core: Detach storage domain when remove Storage Pool. ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/27307/18/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java: Line 164: Line 165: List<VDS> vdss = getAllRunningVdssInPool(); Line 166: for (StorageDomain storageDomain : storageDomains) { Line 167: if (storageDomain.getStorageDomainType() != StorageDomainType.Master) { Line 168: detachStorageDomainWithEntities(storageDomain); there's are few issues here 1. if you fail to detach/remove the domain (Executed in line 169) for whatever reason, you will have all the ovf data in the unregesitered table although it failed. 2. also, if we remove the domain it seems that we don't need to save the unregistered data at all (only when detaching) which is currently wrong for non local dc and for local dc as well. Line 169: if (!removeDomainFromPool(storageDomain, vdss.get(0))) { Line 170: log.errorFormat("Unable to detach storage domain {0} {1}", Line 171: storageDomain.getStorageName(), Line 172: storageDomain.getId()); -- To view, visit http://gerrit.ovirt.org/27307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I120c6b001a197e65528edb73375b379f76d24cd5 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
