Oved Ourfali has posted comments on this change. Change subject: aaa: Intorduce filters ......................................................................
Patch Set 13: (2 comments) some minor comments/questions. will go over it in more depth now. http://gerrit.ovirt.org/#/c/28022/13/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java: Line 68: } Line 69: return result; Line 70: } Line 71: Line 72: // private void handleCredentials(ServletRequest request, String qualified, String password, int index) { remove comment Line 73: private void handleCredentials(ServletRequest request, String[] creds) { Line 74: if (creds != null && creds.length == 2 && getSeparator(creds[0]) != -1) { Line 75: int index = getSeparator(creds[0]); Line 76: String user = null, profileName = null; http://gerrit.ovirt.org/#/c/28022/13/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java: Line 117: if (session != null) { Line 118: if (!FiltersHelper.isAuthenticated(req) && req.getAttribute(FiltersHelper.Constants.AUTH_RECORD_KEY) == null) { Line 119: // We need to remember which of the profiles was managing the negotiation with the client, so we store a Line 120: // stack Line 121: // of the available authenticators in the session: will there be more than one? Line 122: @SuppressWarnings("unchecked") Line 123: Deque<String> stack = (Deque<String>) session.getAttribute(STACK_ATTR); Line 124: if (stack == null) { Line 125: stack = new ArrayDeque<String>(); -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
