Yair Zaslavsky has posted comments on this change. Change subject: aaa: Intorduce filters ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/28022/8/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java: Line 23: public class BasicAuthenticationFilter implements Filter { Line 24: Line 25: private static enum UserNameFormat { Line 26: UPN, Line 27: DOWN_LEVEL_LOGON_NAME > interesting name :) I have found this on microsoft site. http://msdn.microsoft.com/en-us/library/windows/desktop/aa380525(v=vs.85).aspx Is profile\user (or domain\user) REST API specific? Line 28: }; Line 29: Line 30: private static Log log = LogFactory.getLog(BasicAuthenticationFilter.class); Line 31: private UserNameFormat userNameFormat; Line 48: chain.doFilter(request, response); Line 49: String headerValue = req.getHeader("Authorization"); Line 50: if (headerValue != null && headerValue.startsWith("Basic ")) { Line 51: String credentials = headerValue.substring("Basic".length()); Line 52: String userPass = new String(Base64.decodeBase64(credentials), Charset.defaultCharset().toString()); > are you sure you need userPass temp variable? Ok, I wasn't sure here about encoding, thanks. Line 53: String[] creds = userPass.split(":", 2); Line 54: if (creds != null && creds.length == 2) { Line 55: handleCredentials(request, creds[0], creds[1], getSeparator(creds[0])); Line 56: } http://gerrit.ovirt.org/#/c/28022/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: > I still think we should split this base command into two... one that is cal I'm not against that. I would prefer to defer this for later on and finish the other things first. Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import java.text.ParseException; Line 4: import java.text.SimpleDateFormat; -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
