Frank Kobzik has posted comments on this change.

Change subject: backend: RNG device sources reporting
......................................................................


Patch Set 26:

(1 comment)

http://gerrit.ovirt.org/#/c/22258/26/packaging/dbscripts/create_views.sql
File packaging/dbscripts/create_views.sql:

Line 754: vds_spm_id_map ON vds_static.vds_id = vds_spm_id_map.vds_id;
Line 755: 
Line 756: 
Line 757: 
Line 758: CREATE OR REPLACE VIEW vds_with_tags
> i'm not sure either. i didn't include in it last patchset so far. there are
i was advised to add it there, so be it.
Line 759: as
Line 760: SELECT     vds_groups.vds_group_id, vds_groups.name AS 
vds_group_name, vds_groups.description AS vds_group_description, 
vds_groups.architecture as architecture,
Line 761:                       vds_static.vds_id, vds_static.vds_name, 
vds_static.ip, vds_static.vds_unique_id,
Line 762:                       vds_static.host_name, 
vds_static.free_text_comment, vds_static.port, vds_static.vds_strength, 
vds_static.server_SSL_enabled, vds_static.vds_type,


-- 
To view, visit http://gerrit.ovirt.org/22258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id60a39118aef439146e6f0f308eec84e1ccaab9a
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to