Yair Zaslavsky has posted comments on this change. Change subject: aaa: Intorduce filters ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/28022/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SessionValidationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SessionValidationFilter.java: Line 41: parameters.setSessionId(engineSession); Line 42: if (backend.runPublicQuery(VdcQueryType.ValidateSession, parameters).getSucceeded()) { Line 43: authenticated = true; Line 44: } Line 45: ctx.close(); > this should be in finally Done Line 46: httpSession.setAttribute("authenticated", authenticated); Line 47: chain.doFilter(request, response); Line 48: Line 49: } catch (Exception ex) { Line 42: if (backend.runPublicQuery(VdcQueryType.ValidateSession, parameters).getSucceeded()) { Line 43: authenticated = true; Line 44: } Line 45: ctx.close(); Line 46: httpSession.setAttribute("authenticated", authenticated); > no need for authenticated, just set it directory with the getSucceeded. Done Line 47: chain.doFilter(request, response); Line 48: Line 49: } catch (Exception ex) { Line 50: Line 47: chain.doFilter(request, response); Line 48: Line 49: } catch (Exception ex) { Line 50: Line 51: } > do not swallow excpetions Done Line 52: } Line 53: } Line 54: Line 55: @Override Line 53: } Line 54: Line 55: @Override Line 56: public void destroy() { Line 57: } > not sure you must override this all overrides occur as this is an interface. Line 58: -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
