Vojtech Szocs has posted comments on this change. Change subject: build: added maven variable for gwt css obfuscation ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27895/1/frontend/webadmin/modules/pom.xml File frontend/webadmin/modules/pom.xml: Line 63: <gwt.locale>en_US</gwt.locale> Line 64: <!-- By default, engine port is 8080 --> Line 65: <engine.port.http>8080</engine.port.http> Line 66: <!-- GWT CSS obfuscation style. production should be 'obf', use 'pretty' in development for easier css debugging --> Line 67: <gwt.cssObfuscationStyle>obf</gwt.cssObfuscationStyle> > As you can see on line 84 in [1], 'obf' is the default, and I'm not changin Why not simply "gwt.cssResourceStyle" to make it more related to "CssResource.style" GWT property? CssResource is used through ClientBundle and represents <ui:style> part of UiBinder template, so I think that property with name containing "CssResource" would be more appropriate. Line 68: </properties> Line 69: <dependencyManagement> Line 70: <dependencies> Line 71: <!-- Exclude Guice dependencies from GIN --> -- To view, visit http://gerrit.ovirt.org/27895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdc4b08f47a2e1570b07037ff30fc4705f308b0a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
