Martin Sivák has posted comments on this change. Change subject: engine: Make NetworkPolicyUnit aware of multiple clusters ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27990/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java: Line 29 Line 30 Line 31 Line 32 Line 33 > The issue with this class is moving from a stateless to a stateful (impleme Well I killed the variables in the patch (your comment is in the existing code section). I replaced them with a cache Map that is transparently updated whenever it detects display network changes. So it now behaves as a stateless class. If we support couple of thousand networks then we need the cache, because looking for a display network every time we start or migrate a VM will get too slow. -- To view, visit http://gerrit.ovirt.org/27990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e85a81fa4a2248750f480e85e63096c118d25cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
